Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Heartbeat] Bump Node to 18.18 #3655

Merged
merged 4 commits into from
Oct 27, 2023
Merged

[Heartbeat] Bump Node to 18.18 #3655

merged 4 commits into from
Oct 27, 2023

Conversation

emilioalvap
Copy link
Contributor

@emilioalvap emilioalvap commented Oct 25, 2023 •
edited by vigneshshanmugam
Loading

What does this PR do?

Why is it important?

Bump NodeJS version bundled with Heartbeat to 18.18.2.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

How to test this PR locally

  1. Build mage package locally.
  2. Run a container with the generated image.
  3. Execute the following command and test version matches 18.18.2:
docker run --rm --entrypoint /bin/bash docker.elastic.co/beats/elastic-agent-complete:<version> -c "node --version"
v18.17.1

@emilioalvap emilioalvap added bug Something isn't working Team:Uptime Label for the Uptime team v8.11.0 backport-v8.10.0 Automated backport with mergify backport-v8.11.0 Automated backport with mergify labels Oct 25, 2023
@emilioalvap emilioalvap requested a review from a team as a code owner October 25, 2023 15:37
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 25, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-27T14:01:25.335+0000

  • Duration: 67 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 6553
Skipped 59
Total 6612

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@emilioalvap emilioalvap changed the title [Heartbeat] Bump Node to 18.17 [Heartbeat] Bump Node to 18.18 Oct 25, 2023
@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Oct 25, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

pierrehilbert
pierrehilbert approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@pierrehilbert pierrehilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

changelog/fragments/1698247934-hb-bump-node.yaml Outdated
# - security: impacts on the security of a product or a user’s deployment.
# - upgrade: important information for someone upgrading from a prior version
# - other: does not fit into any of the other categories
kind: bug-fix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a bug-fix, other than that, LGTM.

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 25, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.824% (84/85) 👍
Files 66.885% (204/305) 👍
Classes 65.95% (368/558) 👍
Methods 53.041% (1160/2187) 👍
Lines 39.386% (13670/34708) 👍 0.014
Conditionals 100.0% (0/0) 💚

@emilioalvap emilioalvap removed the backport-v8.10.0 Automated backport with mergify label Oct 26, 2023
@emilioalvap
Copy link
Contributor Author

/test

1 similar comment
@emilioalvap
Copy link
Contributor Author

/test

@elastic-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@emilioalvap emilioalvap merged commit 318a4bc into elastic:main Oct 27, 2023
8 checks passed
mergify bot pushed a commit that referenced this pull request Oct 27, 2023
@emilioalvap @mergify
[Heartbeat] Bump Node to 18.18 (#3655)
b0b1e55 
Bump NodeJS version bundled with Heartbeat to 18.18.2.

(cherry picked from commit 318a4bc)
@mergify mergify bot mentioned this pull request Oct 27, 2023
Merged
belimawr pushed a commit to belimawr/elastic-agent that referenced this pull request Nov 28, 2023
@mergify @emilioalvap
[Heartbeat] Bump Node to 18.18 (elastic#3655) (elastic#3671)
adfd1d7 
Bump NodeJS version bundled with Heartbeat to 18.18.2.

(cherry picked from commit 318a4bc)

Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshshanmugam vigneshshanmugam vigneshshanmugam approved these changes

@pierrehilbert pierrehilbert pierrehilbert approved these changes

@andrewvc andrewvc Awaiting requested review from andrewvc

@AndersonQ AndersonQ Awaiting requested review from AndersonQ AndersonQ is a code owner automatically assigned from elastic/elastic-agent-control-plane

@pchila pchila Awaiting requested review from pchila pchila is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@emilioalvap emilioalvap

Labels
backport-v8.11.0 Automated backport with mergify bug Something isn't working Team:Elastic-Agent Label for the Agent team Team:Uptime Label for the Uptime team v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emilioalvap @elasticmachine @pierrehilbert @vigneshshanmugam